Skip to content

feat(parsers.graphite): Implement ParserTimeFuncPlugin interface#18948

Merged
skartikey merged 2 commits into
influxdata:masterfrom
srebhan:parser_graphite
May 29, 2026
Merged

feat(parsers.graphite): Implement ParserTimeFuncPlugin interface#18948
skartikey merged 2 commits into
influxdata:masterfrom
srebhan:parser_graphite

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented May 20, 2026

Summary

This PR implements the ParserTimeFuncPlugin interface for the plugin.

Checklist

Related issues

@telegraf-tiger telegraf-tiger Bot added area/graphite feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels May 20, 2026
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 20, 2026
skartikey
skartikey reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks! Please take a look at the comment.

Comment thread plugins/parsers/graphite/parser.go Outdated
@srebhan srebhan requested a review from skartikey May 27, 2026 13:10
skartikey
skartikey reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan One minor comment.

Comment thread plugins/parsers/grok/parser.go Outdated
@srebhan srebhan force-pushed the parser_graphite branch from 0043f10 to e56d31b Compare May 29, 2026 09:23
@srebhan srebhan requested a review from skartikey May 29, 2026 09:23
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger Bot commented May 29, 2026

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

skartikey
skartikey approved these changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks!

@skartikey skartikey merged commit 153d3c7 into influxdata:master May 29, 2026
26 of 27 checks passed
@github-actions github-actions Bot added this to the v1.39.0 milestone May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skartikey skartikey skartikey approved these changes

Assignees

@skartikey skartikey

Labels

area/graphite feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.39.0

Development

Successfully merging this pull request may close these issues.

2 participants

@srebhan @skartikey